search

kjanoudi / joiful-react-forms

Automatically generate validated React forms using the Joi schema!
10 stars 1 forks source link

Element Types in props were ignored #30

Open jaulz opened 8 years ago

bentatum commented 8 years ago

I think we were looking to deprecate the elementTypes prop. Either use the is prop on the Input element or provide that in joifulReactForms context object.

jaulz commented 8 years ago

@bentatum Just for future reference: how do you plan to implement custom elementTypes then? Only by context?

bentatum commented 8 years ago

You can do it in context or directly on the is prop.

And I think next version we want to move to a higher order component pattern.

bentatum commented 8 years ago

I would accept a PR removing elementTypes 😃

bentatum commented 8 years ago

Thanks again for the contributions. We're both really busy, but we use this package quite a bit. It definitely needs more love.

jaulz commented 8 years ago

Okay, I will check that as well :)