search

kjappelbaum / element-coder

Encode chemical elements numerically and decode numerical representations of elements.
https://element-coder.readthedocs.io/en/latest/?badge=latest
MIT License
9 stars 0 forks source link

Python 3.7 compatibility #14

Closed sgbaird closed 2 years ago

sgbaird commented 2 years ago

Do you know what's specific to the Python > 3.8 requirement in setup.cfg? E.g. certain packages or coding conventions that you use that require 3.8+

kjappelbaum commented 2 years ago

I'll double-check this, but I think we can relax it to >= py3.7. It is due to sciris (https://github.com/sciris/sciris/issues/122#issuecomment-1183478440). However, I'm considering dropping the sciris dependency as it makes many issues ...

sgbaird commented 2 years ago

Good to know! Thanks for the quick responses.

sgbaird commented 2 years ago

Planning to use element-coder within matbench-genmetrics. The sciris dependency does seem to have quite a few requirements. Do you think you'll keep sciris?

kjappelbaum commented 2 years ago

Let's drop it 🥴😀

sgbaird commented 2 years ago

😓 😅