kjappelbaum / mofdscribe

An ecosystem for digital reticular chemistry
https://mofdscribe.readthedocs.io/en/latest/
MIT License
43 stars 8 forks source link

implement BB mismatch featurizer #153

Closed kjappelbaum closed 2 years ago

kjappelbaum commented 2 years ago

get a feature vector that measures the mismatch of a given feature vector with a library of topologies.

For now, we do not need to depend on the moffragmentor. We can just accept a structure object that has some kind of atoms on the connecting sites. Then we use the rmsd code to get the mismatches with the topologies.

Not sure if we should depend on pormake for this or not. My intuition is that this is not really needed for now and we can just ship our own library of topologies protostructures

kjappelbaum commented 2 years ago

implemented in https://github.com/kjappelbaum/mofdscribe/commit/cc521cadf1b14c896686fbd985cca309e8523ae7