search

kjappelbaum / oximachine_featurizer

featurizing MOFs for the oximachine
MIT License
7 stars 4 forks source link

package 'test' installed #37

Closed ltalirz closed 3 years ago

ltalirz commented 3 years ago

you're trying to avoid this here https://github.com/kjappelbaum/oximachine_featurizer/blob/master/setup.py#L63

but since the folder is called test , it slips through

$ pip uninstall oximachine-featurizer
Found existing installation: oximachine-featurizer 0.2.14
Uninstalling oximachine-featurizer-0.2.14:
  Would remove:
    /Users/leopold/Applications/miniconda3/envs/aiida-lsmo-2/bin/run_featurization
    /Users/leopold/Applications/miniconda3/envs/aiida-lsmo-2/bin/run_mine_mp
    /Users/leopold/Applications/miniconda3/envs/aiida-lsmo-2/bin/run_parsing
    /Users/leopold/Applications/miniconda3/envs/aiida-lsmo-2/bin/run_parsing_reference
    /Users/leopold/Applications/miniconda3/envs/aiida-lsmo-2/lib/python3.8/site-packages/oximachine_featurizer-0.2.14.dist-info/*
    /Users/leopold/Applications/miniconda3/envs/aiida-lsmo-2/lib/python3.8/site-packages/oximachine_featurizer/*
    /Users/leopold/Applications/miniconda3/envs/aiida-lsmo-2/lib/python3.8/site-packages/run/*
    /Users/leopold/Applications/miniconda3/envs/aiida-lsmo-2/lib/python3.8/site-packages/test/*
  Would not remove (might be manually added):
    /Users/leopold/Applications/miniconda3/envs/aiida-lsmo-2/lib/python3.8/site-packages/test/test_oximachine.py
ltalirz commented 3 years ago

I've accidentally done the same in the past and it led me to question whether the find_packages() approach is really the most sensible default. Most of the time one anyhow just wants to install one package.

kjappelbaum commented 3 years ago

ups, thanks for spotting!

kjappelbaum commented 3 years ago

i switched to using include= ...