search

kjayma / surveyor_gui

An extension to nubic/surveyor that adds reports and a forms to build surveys
MIT License
45 stars 42 forks source link

Rails 4.1 support #24

Closed Sjors closed 10 years ago

Sjors commented 10 years ago

I made an initial attempt here, by simply commenting out a few lines of code. I'm currently able to run the rake tasks, create and fill out a survey.

kjayma commented 10 years ago

does it still run in Rails 4.0 with these changes?

Sjors commented 10 years ago

I don't know. I don't recommend merging these changes; I've never used this gem or surveyor itself before, I have no idea what I just commented out and I'm still getting various crashes in other places (possibly unrelated to Rails 4.1).

kaushiktiwari commented 10 years ago

Was getting similar rails 4.1.1 error.

Used this in the gemfile. gem 'surveyor_gui', git: 'git://github.com/Sjors/surveyor_gui.git', :branch => 'rails-4.1'

Bundle install worked fine. Still to find out whether there are other crashes.

kjayma commented 10 years ago

If you're using postgre, like Sjors, you'll need to pull in the last two commits from master.

kjayma commented 10 years ago

Erroneously closed. Turns out tests did not pass.