search

kjb085 / MMM-Reddit

Magic Mirror Module for displaying top level content from reddit
34 stars 7 forks source link

Some extra functionality.. #7

Open Mark-papi opened 5 years ago

Mark-papi commented 5 years ago

Hello, Your module is really cool, one extra functionality could be gif's getting them from reddit and fetch them.

Again, thank you for your module!!

kjb085 commented 5 years ago

Thanks, I appreciate the kind words; I'm glad to hear you like it!

As far as implementing gifs, it's honestly something that I'd love to do, but it definitely presents some interesting challenges in order to do well. I would need to be able to ensure that the gif can complete a run before cycling to the next post or set of posts. I did some preliminary exploration of this during the initial build of the module and as far as I can tell, with standard gifs, there's no way to handle this. The good news is that with the gifv format there's potential to be able to add a hook to end of a gif such that the desired functionality could be achieved. Due to this, I don't know if I'll be able to get any given gif posted to reddit to display in a module, but we might be able to get most of the way there depending on the prevalence of gifv support. I'm on a bit of an open source work kick at the moment, so depending on my bandwidth in the coming month, it's something that I may look into, but I can't make a promise that it will be added as I have one other project which requires attention and one that's in its initial development as well.

I'm sure that's way more information than you were looking for, but the tl;dr of it is hopefully soon, but ultimately maybe.

WolfShadowheart commented 4 years ago

It would probably required an alternate code but maybe something like when the gif ends move onto the next post, with the ability to repeat before moving on?