Looking good here Kevin, showtime is definitly dockerized - it's running perfectly on my system.
In dev, I had to make some key changes - you may consider adding Dockerfile.dev so that anyone can run the project in docker if they wish.
in your compose.yaml I replaced the image key with build: .
in Dockerfile I changed build dependencies to use both dependencies and added migrations.
I am requesting those changes:
[x] Because the dockerfile is not available in the repo or on a container hub, remove the image key and replace it with build: .
[x] Add environment variables in the compose.yaml or add a .env-template in git repo
[x] Set the build dependencies to dev, or both or adjust. I needed both dev and prod dependencies to run the project.
[x] Add a readme for how to runt he project in docker (and test the steps).
Thanks, Ryan. I appreciate the suggestions!
Here are some keys changes from my side.
The application is now built with Docker compose when called.
The environment variables are now fed into the image without having to copy the .env into it.
README.md has been updated.
I was facing some issues with building the project and running it like a development environment. Building the container with gunicorn is much more straightforward and will look to run a container with manage.py at a later time.
Thanks, Ryan. I appreciate the suggestions!
Here are some keys changes from my side.
The application is now built with Docker compose when called.
The environment variables are now fed into the image without having to copy the .env into it.
README.md has been updated.
I was facing some issues with building the project and running it like a development environment. Building the container with gunicorn is much more straightforward and will look to run a container with manage.py at a later time.