NEricN commented 7 years ago

The behavior before the changes to the special attributes was that spaces were not allowed. This allows for not accidentally making content inside {brackets} disappear. This readds that requirement that spaces are not allowed between a codespan or a link and their special attributes.

codecov-io commented 7 years ago

Codecov Report

Merging #39 into master will increase coverage by -0.02%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   62.54%   62.52%   -0.02%     
==========================================
  Files          14       14              
  Lines        3879     3877       -2     
  Branches     1042     1041       -1     
==========================================
- Hits         2426     2424       -2     
  Misses       1023     1023              
  Partials      430      430

Impacted Files	Coverage Δ
src/document.c	`73.15% <ø> (-0.03%)`	:x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d971e29...f9e0d59. Read the comment docs.

NEricN commented 7 years ago

The coverage is less because code that wasn't working as intended is removed. Whitespace doesn't matter inside special attributes, and are skipped anyways. Let me know if the failing test is a blocker.

kjdev commented 7 years ago

Thanks.

kjdev / hoextdown

Fix issue where inline special attributes were fine with spaces. #39

Codecov Report