search

kjdev / hoextdown

Hoextdown is an extension to Hoedown
MIT License
23 stars 15 forks source link

Improve handling of fenced code inside list items #60

Closed gagern closed 4 years ago

gagern commented 4 years ago

This fixes two major issues I observed from my recent https://github.com/kjdev/hoextdown/pull/58. It avoids treating same-line code spans as code fences, and it takes the indentation of an opening fence in the first line into account correctly.

This is far from perfect, and in particular it is known not to be very clever when it comes to matching different kinds of code fences. https://github.com/kjdev/hoextdown/issues/59 is discussing a lot of related problems. But in practice, this here should be enough to address a large number of situations where https://github.com/kjdev/hoextdown/pull/58 might otherwise make things worse.

gagern commented 4 years ago

GitHub appears to be having issues reporting the Travis status. From the Travis page itself the tests appear to have been run successfully, but GitHub shows them as pending. Hope this doesn't confuse machinery required to review this change.

kjdev commented 4 years ago

Thanks.