search

kjdev / php-ext-brotli

Brotli Extension for PHP
MIT License
172 stars 29 forks source link

Missing test data in PECL package #17

Closed andypost closed 5 years ago

andypost commented 5 years ago

I used to remove tests packaging extension in https://github.com/alpinelinux/aports/pull/5942

=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
Test compatibility [tests/compatibility.phpt]
Test compatibility [tests/roundtrip.phpt]
=====================================================================

The code

# tests/compatibility.phpt
...
$dir = dirname(__FILE__) . '/../brotli/tests/testdata/*.compressed*';

# tests/roundtrip.phpt
$dir = dirname(__FILE__) . '/../brotli/';
$files = array(
    'tests/testdata/alice29.txt',
    'tests/testdata/asyoulik.txt',
    'tests/testdata/lcet10.txt',
    'tests/testdata/plrabn12.txt',
    '/c/enc/encode.c',
    '/c/common/dictionary.h',
    '/c/dec/decode.c',
);
kjdev commented 5 years ago

2b34b2d6e5a3301084d021098317246ba1818cf7 Fix to skip tests that depend on brotli library files

andypost commented 5 years ago

Thanks for fixing it, Alpine now using one more patch https://github.com/alpinelinux/aports/pull/7759