allow to use system brotli library

remicollet commented 7 years ago

config.m4 is broken for RC versions, so I switch to test PHP_VERSION_ID, which seems simpler

btw, perhaps this check can even be removed (PHP 4 still exists ?)

building using --with-libbrotli will ignore the bundled library and use the system one.

Tested (build + tests) with broti version 0.6.0 (available in Fedora) with PHP 5.4.45, 5.5.38, 5.6.32, 7.0.25, 7.1.12RC1 and 7.2.0RC6

Notice: using bundled library is usually forbidden in Linux distro (at least higly discouraged)

Bundled version is no more in php_brotly.h but instead in config.m4 AC_DEFINE_UNQUOTED(BROTLI_LIB_VERSION, "1.0.1", [bundled library version])

Minimal supported version is also define in config.m4 BROTLI_MIN_VERSION=0.6

remicollet commented 7 years ago

According to https://github.com/kjdev/php-ext-brotli/commit/a06a8d42522b76b508cd21973e194c68e38e84ab there is some change making 0.5.0 not compatible, reason why I set minimal version to 0.6.0

kjdev commented 7 years ago

Thanks.

kjdev / php-ext-brotli