search

kjdev / php-ext-zstd

Zstd Extension for PHP
MIT License
201 stars 27 forks source link

ztsd_uncompress may return a empty string #27

Closed remicollet closed 4 years ago

remicollet commented 4 years ago

With current version

$ php -r 'var_dump(zstd_uncompress(zstd_compress("")));'
bool(false)

With this fix

$ php -n -d extension=modules/zstd.so  -r 'var_dump(zstd_uncompress(zstd_compress("")));'
string(0) ""

From ZSTD_compress doc: * note 1 : a 0 return value means the frame is valid but "empty".

remicollet commented 4 years ago

Notice, we may also want to use RETVAL_EMPTY_STRING is such case.... (less allocation, returns an interned string)

kjdev commented 4 years ago

Thanks.