Closed remicollet closed 5 months ago
The recent updates to the codebase focus on enhancing compatibility and precision in the Zstandard compression library. Specifically, there's a shift in data type for compression levels to ensure broader compatibility across different platforms. The zstd.c
file sees adjustments in function parameters and error handling, aiming for a more robust and error-resilient implementation.
File(s) | Summary of Changes |
---|---|
zstd.c |
- Changed level parameter type to zend_long in zstd_check_compress_level - Cast level to int in zstd_compress and zstd_compress_dict - Updated error message formatting in APC_UNSERIALIZER_NAME(zstd) |
🐇✨
In the world of code, where compression's king,
A rabbit hopped by, making changes sing.
With a tweak and a cast, errors take flight,
For a faster, safer compression delight.
🚀🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Previous broken build: https://koji.fedoraproject.org/koji/taskinfo?taskID=112371673 New build using this patch: https://koji.fedoraproject.org/koji/taskinfo?taskID=112452647
No build errors or warnings on all arches
thanks
Using GCC 14 on Fedora 40 this is now a build error:
Summary by CodeRabbit