Get set up on semantic-release

[wraithgar]

greenkeeper apparently broke things?

This issue is now about switching to semantic-release

[gr2m]

did you get it working? What happened? Ping me if I can help with anything :)

[wraithgar]

Yes I got it working, it was a combination of two things, first a misunderstanding on my part of exactly how greenkeeper works (it relies on existing CI tests to tell you if the build breaks). Second, some hapi tweaks that changed in newer versions that exposed a duplicate .connection call I was making in the tests, and then also meant we don't have 100% coverage anymore cause newer hapi doesn't send OPTIONS requests to the plugin anymore. It's all good now and today I guess I should finally knuckle down and learn travis myself or something (haven't done CI in any of my personal projects yet)

[gr2m]

I’m happy to help with any questions regarding greenkeeper.io. I can also very, very much recommend semantic-release. It does the whole CI setup for you and releases new versions automatically based on a few commit conventions. Happy to help with that, too

[wraithgar]

Thanks, I looked into semantic-release and it looks nice. How does it work on pull requests? I'd like to cut a major release since we bumped the boom version that gets returned from this module from 2 to 3. Is that doable now that the commits are already in place or is this a "going forward" kind of module?

[wraithgar]

Trip report: will set this repo up once this issue is closed https://github.com/semantic-release/semantic-release/issues/114

[gr2m]

it’s a going forward kind of module. You can push an empty commit

git commit --allow-empty -m 'chore: major version bump

BREAKING CHANGE:

Bumped [boom](https://www.npmjs.com/package/boom) from to version 3. Changelog: <insert link here>

[gr2m]

Can you please try to change the package.json and see if that helps?

-  "repository": {
-    "type": "git",
-    "url": "git@github.com:wraithgar/hapi-json-api.git"
-  },
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/wraithgar/hapi-json-api.git"
+  },

[wraithgar]

That worked, set it up, committed, semantic-release failed with:

semantic-release ERR! pre Failed to determine new version.
semantic-release ERR! pre ENOCHANGE There are no relevant changes, so no new version is released.

I think I didn't format my message right, will try again w/ an empty commit.

[wraithgar]

Looks like it worked, waiting for 2.0 to show up on npm now.

[wraithgar]

Yay 2.0 in the pipe, thanks

[gr2m]

Nice :+1: https://github.com/wraithgar/hapi-json-api/releases/tag/v2.0.0