kjellmorten / hapi-json-api

Hapi plugin for enabling/enforcing JSON-API specification.
MIT License
44 stars 5 forks source link

workaround Firefox Bug sending charset=utf-8 media type parameter #11

Closed gr2m closed 8 years ago

gr2m commented 8 years ago

Hey @wraithgar, would you accept a PR to workaround Firefox’ bug described here? https://github.com/json-api/json-api/issues/837

gr2m commented 8 years ago

hhmmm I’m trying to commit something for a PR, but I get a lint error:

$ gc test/ -m 'test: ignore charset=utf-8 media type parameter'
running lint...passed!
running validate...passed!
running test...failed!

/Users/gregor/Projects/hapi-json-api/node_modules/lab/lib/cli.js:5
const Fs = require('fs');
^^^^^
SyntaxError: Use of const in strict mode.

Any idea?

gr2m commented 8 years ago

I worked around it by temporarily remove "test" in package.json’s "pre-commit"

wraithgar commented 8 years ago

Not sure why tests aren't working locally for you, they are for travis-ci at least. Typically this happens when you've switched to a pre-es6 version of node or something.