search

kjellmorten / hapi-json-api

Hapi plugin for enabling/enforcing JSON-API specification.
MIT License
44 stars 5 forks source link

chore(tests) add validation tests #21

Closed wraithgar closed 7 years ago

wraithgar commented 8 years ago

Ensure that failed validation returns proper objects through various points along the request lifecycle, including with a failAction configured.

This is an attempt at nailing down #20. Not ready to merge yet because I can't reproduce it in tests yet.

wraithgar commented 8 years ago

To be honest those commit conventions confused the heck out of me and I'm having trouble keeping in line with them. I am probably going to be removing the semantic-release plugin from this repo cause I was never able to properly wrap my head around it, sorry.

gr2m commented 8 years ago

okay, for semantic-release, you need to remember 3 things only, you can ignore the rest entirely

  1. fix: ... prefix will bump the patch version
  2. feat: .. prefix will bump the minor version
  3. BREAKING CHANGE: in commit body (not first line) will bump major version

all the other stuff like test: ..., chore: ..., docs: ..., refactor: ..., style: ... and what not is not relevant for semantic-release.

But these three above are great because they are used to automate new version numbers, releases on npm, git tags on github, releases on github and changlogs in releases on github. Give it a try, I really think this is great, worth giving it a proper shot