kjellmorten / hapi-json-api

Hapi plugin for enabling/enforcing JSON-API specification.
MIT License
44 stars 5 forks source link

ignore non-JSON API requests #7

Closed gr2m closed 8 years ago

gr2m commented 8 years ago

workaround for #6

wraithgar commented 8 years ago

Looks good to me, ship it, with a test if you want to (I will try to get to it if you don't want to do that).

wraithgar commented 8 years ago

Patch release imo.

gr2m commented 8 years ago

Nice thanks, I'll update the PR with a nest, thanks Gar :)

gr2m commented 8 years ago

args sorry, accidentally pushed to master now. Oh man, this usually does not happen to me :/

But I think the commits are ok:

  1. 6245f4e
  2. 2705bb1

Let me know if you want anything changed

gr2m commented 8 years ago

if it looks good to you, I can do the release, otherwise let me know and I get it fixed first. Sorry again :(

wraithgar commented 8 years ago

Oh hey yeah an internals function, very nice. Ship it. Thank you so much.

gr2m commented 8 years ago

done :tada:

I've added semantic-release to all my repos, it automatically publishes new versions based on the commit messages via travis, and also creates tags & releases on Github. Setup is super easy: https://github.com/semantic-release/semantic-release#setup

Highly recommended :) You will never look back, word on that. Happy to help with any questions you have on semantic-release