This relies on cost() and has_cost() being removed from AtteanX::Store::SPARQL::Plan::BGP. It works for me by just commenting them out, but then it breaks tests in p5-atteanx-store-sparql that rely on those methods. I'd recommend:
Moving the cost() method into AtteanX::Model::SPARQL
Updating the p5-atteanx-store-sparql tests to create a AtteanX::Model::SPARQL model, and test against it's cost_for_plan method
After that's done, and assuming I've understood all the tests, this PR should make everything in t/simple-sparql-planner.t pass.
t/analysis.t still fails for me. I haven't looked into that code yet. Can you let me know if I should keep digging into that, or if this PR resolves some of the issues?
This relies on cost() and has_cost() being removed from AtteanX::Store::SPARQL::Plan::BGP. It works for me by just commenting them out, but then it breaks tests in p5-atteanx-store-sparql that rely on those methods. I'd recommend:
After that's done, and assuming I've understood all the tests, this PR should make everything in t/simple-sparql-planner.t pass.
t/analysis.t still fails for me. I haven't looked into that code yet. Can you let me know if I should keep digging into that, or if this PR resolves some of the issues?
Thanks!