search

kjhall01 / xcast

A High-Performance Data Science Toolkit for the Earth Sciences
MIT License
65 stars 5 forks source link

ELR needs "threshold_type" kwarg #17

Closed kjhall01 closed 2 years ago

kjhall01 commented 2 years ago

ELR here uses thresholds in the range [0, 1] when it should, probably, be [mindata, maxdata].

The threshold and the input should be scaled to the same range.

kjhall01 commented 2 years ago

hard-coded to use threshold in y-units. closing