kjk / dbworkbench

Database workbench for Mac and Windows
MIT License
5 stars 1 forks source link

getMacSerial crash #75

Closed thellimist closed 8 years ago

thellimist commented 8 years ago

https://github.com/kjk/dbworkbench/commit/7beb84336aba263cd0e0cb29a5f1f6f6a5fd47f7

Does this commit solve that problem? The version 0.1.9 still gives the crash.

kjk commented 8 years ago

It should but given I can't reproduce this on any of my machines, it's just guesswork.

thellimist commented 8 years ago

Also it gives en0 for me which is Wi-fi which is correct I suppose. But can we ensure that Ethernet Address is unique for every computer?

kjk commented 8 years ago

Your guess is as good as mine. In theory they should be unique.

kjk commented 8 years ago

This should be fixed by getting mac address.

thellimist commented 8 years ago

the user said bug was we didn't count as an identified developer. When he changed the settings to anywhere he could run without crash. It doesn't seem correct but that was his case.

kjk commented 8 years ago

Strange. I have the same settings and I just re-tried 0.1.8 and it didn't crash.

thellimist commented 8 years ago

I did the same and worked. But apparently that fixed somehow