Open hongxuchen opened 5 years ago
Intentional. If you check the same page you linked, it will tell you the git repo does not
contain any autgenerated files (configure
) or third-party code (all of lib
).
Thanks for clarification and sorry I didn't read the content on that page or the BOOTSTRAP file carefully.
Personally I think it's better to mention BOOTSTRAP file or ./build-aux/autogen.sh
in README.
Although I generally don't like checking generated files into SCM, I am now considering adding Gnulib and Autotools-generated build files into Git repository to ease contribution and to make release tarballs closer (or identical) to contents of the repository.
@kjn bit late, but I'd personally suggest against it. Too much churn, what @HongxuChen said about mentioning it may be enough.
I partially agree with @hanetzer – it is a bad idea to check files generated by Autotools into the source repository. However, gnulib files aren't generated so it might make sense to include them. An alternative would be to add the gnulib source repository as a Git submodule. (I have seen other projects that depend on gnulib do this.) You would still need to provide a bootstrap script (or at least remind developers to do a git submodule init;git submodule update
or to clone the repository recursively) but at least you won't be unnecessarily duplicating any gnulib code in your repository, and you have an easy, enforceable way of specifying which version of gnulib to include in the source distribution (since submodules always point to a specific commit ID).
The
lib
directory that contains Gnulib C files seems missing from this repository, despite that it's there inside release versions:http://lbzip2.org/download.