search

kjvarga / sitemap_generator

SitemapGenerator is a framework-agnostic XML Sitemap generator written in Ruby with automatic Rails integration. It supports Video, News, Image, Mobile, PageMap and Alternate Links sitemap extensions and includes Rake tasks for managing your sitemaps, as well as many other great features.
MIT License
2.44k stars 276 forks source link

GoogleStorageAdapter - Allow to create an object without an ACL #397

Closed tkhsh closed 2 years ago

tkhsh commented 2 years ago

Fix https://github.com/kjvarga/sitemap_generator/issues/396

tkhsh commented 2 years ago

@kjvarga Some tests have failed, but it doesn't seem to be the effect of this PR 🤔 It's also happening on the master branch. https://app.circleci.com/pipelines/github/tkhsh/sitemap_generator

tkhsh commented 2 years ago

Some tests have failed, but it doesn't seem to be the effect of this PR 🤔 It's also happening on the master branch.

I found the issue and fixed it in https://github.com/kjvarga/sitemap_generator/pull/399.

kjvarga commented 2 years ago

Thanks for the PR! Merged in https://github.com/kjvarga/sitemap_generator/pull/410