kjvarga / sitemap_generator

SitemapGenerator is a framework-agnostic XML Sitemap generator written in Ruby with automatic Rails integration. It supports Video, News, Image, Mobile, PageMap and Alternate Links sitemap extensions and includes Rake tasks for managing your sitemaps, as well as many other great features.
MIT License
2.44k stars 277 forks source link

Allow disable acl for S3 bucket #398

Closed andrewchen5678 closed 2 years ago

andrewchen5678 commented 2 years ago

Currently it is forcing S3 bucket to have acl = public read, which is not desired for some setup.

It'll be helpful to be able to disable that option.

https://github.com/kjvarga/sitemap_generator/blob/aa69709ac631466b1d7562195343e7cffe1b5b59/lib/sitemap_generator/adapters/aws_sdk_adapter.rb#L43

kjvarga commented 2 years ago

@andrewchen5678 you can now configure the acl option in v6.3.0