kjvarga / sitemap_generator

SitemapGenerator is a framework-agnostic XML Sitemap generator written in Ruby with automatic Rails integration. It supports Video, News, Image, Mobile, PageMap and Alternate Links sitemap extensions and includes Rake tasks for managing your sitemaps, as well as many other great features.
MIT License
2.44k stars 276 forks source link

Ensure eval call knows its line numbers etc #426

Closed olleolleolle closed 2 weeks ago

olleolleolle commented 1 year ago

This PR adds binding and line number information to an eval'd piece of code.

marvindanig commented 1 year ago

Pinging @kjvarga to have some of these pending PRs merged asap. ☝🏼

n-rodriguez commented 10 months ago

Hi there! Any news? ping @kjvarga

n-rodriguez commented 2 weeks ago

@olleolleolle hello! can you please rebase your branch? Thank you!

olleolleolle commented 2 weeks ago

@n-rodriguez Now rebased!

olleolleolle commented 2 weeks ago

I guess the CI configuration has to be unconfigured in the Settings page of this project, so that there are no requirements on CircleCI having finalized.

kjvarga commented 2 weeks ago

@olleolleolle @n-rodriguez I've removed the CircleCI Webhook from settings so it shouldn't show up in the status checks. But looks like we might have to push an empty commit to clear out the errored job.

n-rodriguez commented 2 weeks ago

@olleolleolle @kjvarga Thank you!