search

kk7ds / pynx584

Python library and server for talking to NX584/NX8E interfaces
GNU General Public License v3.0
29 stars 26 forks source link

Host a Home Assistant Add-On in this repo? #72

Open ivmarkov opened 2 years ago

ivmarkov commented 2 years ago

Not a bug really - but JFYI - I just published a very simple Home Assistant Add-On for this server: https://github.com/ivmarkov/nx584

You might consider hosting it here, in this repo.

kk7ds commented 2 years ago

I haven't used HA in years, so I'm not familiar with this. Looks like it's just a structured git repo that HA knows how to grab in order to install components? It also looks like you expect people to fork it for their own configuration. I certainly can fork it here, but it seems better to let you keep it, especially if you're going to maintain it (because I am not). Is there some reason to keep it in my namespace near pynx584 itself?

Maybe this issue should turn into a PR mentioning your repo in the README?

ivmarkov commented 2 years ago

Yes, it is just a structured git repo. If you don't feel like maintaining it, it is OK to stay in my personal org. Adding a reference to it from your README might indeed help folks find it out. If pynx584 is supposed to be used with HA, an add-on is pretty much the norm these days, as it is the easiest way to set it up and make sure it is running OK in the long run.

(As for forking for their own configuration - that's only because the current add-on does not expose ways to configure it. I might fix that in future.)

kk7ds commented 2 years ago

Sorry, I replied to this via email and see that it never got posted here.

Can you submit a PR for a README update that points to your repo with the right words? I can do it, but I think it'd be better if you wordsmith it...if you're willing.

kk7ds commented 1 year ago

Okay, do you want to write up the change to the readme as a PR here? If not I can do it later, but I'll want you to look at it to make sure it makes sense 🙂

From: Ivan Markov @.***> Sent: Sunday, September 11, 2022 08:59 To: kk7ds/pynx584 Cc: Dan Smith; Comment Subject: Re: [kk7ds/pynx584] Host a Home Assistant Add-On in this repo? (Issue #72)

Yes, it is just a structured git repo. If you don't feel like maintaining it, it is OK to stay in my personal org. Adding a reference to it from your README might indeed help folks find it out. If pynx584 is supposed to be used with HA, an add-on is pretty much the norm these days, as it is the easiest way to set it up and make sure it is running OK in the long run. (As for forking for their own configuration - that's only because the current add-on does not expose ways to configure it. I might fix that in future.) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

ivmarkov commented 1 year ago

Sounds like a plan - I'll review your additions to the readme.

juanjoSanz commented 3 months ago

I have improved @ivmarkov repo, mine is configurable from Home Assistant Add-on directly.

https://github.com/juanjoSanz/home-assistant-addons/tree/main/nx584

txwindsurfer commented 2 months ago

@juanjoSanz I just want to report that I installed your improved @ivmarkov repo on my HAOS system, and it is working. I know you indicated not to install in a production environment but that is how I installed with a backup running on an RPI so I can always just move the serial cable. Thank you for you work on this! You have at least 1 happy user.