search

kkAyataka / plusaes

Header only C++ AES cipher library
https://kkayataka.github.io/plusaes/doc/index.html
Boost Software License 1.0
188 stars 41 forks source link

Missing HF in GCM calculation? #35

Closed diedricm closed 1 year ago

diedricm commented 1 year ago

Hi! I may be off the mark here, but shouldn't the gcm calculation for its last block multiply with the encrypted counter 0? I don't really see that in calc_gcm_tag(). See: https://[upload.wikimedia.org/wikipedia/commons/2/25/GCM-Galois_Counter_Mode_with_IV.svg](https://upload.wikimedia.org/wikipedia/commons/2/25/GCM-Galois_Counter_Mode_with_IV.svg)

diedricm commented 1 year ago

Found it in gctr() :) Thanks for the library!