search

kkapsner / CanvasBlocker

A Firefox extension to protect from being fingerprinted.
https://canvasblocker.kkapsner.de
Mozilla Public License 2.0
1.16k stars 87 forks source link

YouTube hanging with 1.10 on Firefox stable builds, downgrade to 1.9 fixes the issue #699

Closed spacesynth closed 7 months ago

spacesynth commented 7 months ago

Description

"A website is slowing Firefox, do you want to stop it?" warnings appearing in the browser. I first suspected uBlock Origin being the culprit, but when I checked only CanvasBlocker was recently updated.

Expected Behaviour

The expected behaviour is that of version 1.9, which was restored as soon as I downgraded. So I strongly believe the upgrade to 1.10 caused the hanging during Youtube video playback. In particular when searching and jumping to offsets in the video.

Current Behaviour

I don't know what further details I could add. A software regression is a type of software bug where a feature that has worked before stops working.

Possible Solution

Downgrade to 1.9

Steps to Reproduce (for bugs)

  1. upgrade to 1.10
  2. the problems appear when searching a youtube video during playback

Context

There is no further explanation needed, really.

Your Environment

Your Settings

Glad to provide them! https://github.com/spacesynth/userscripts-collection/blob/master/addon_settings/CanvasBlocker.json

I'm quoting this guy though: https://github.com/kkapsner/CanvasBlocker/issues/698

As other Google / Alphabet sites seem to be affected.

kkapsner commented 7 months ago

Well... s***

kkapsner commented 7 months ago

I deactivated 1.10 for the time being...

JohnPlanetary commented 7 months ago

I noticed in the Firefox 124.0.2, with CanvasBlocker 1.10, that memory consumption would go from 84 MB (without CanvasBlocker 1.10) in https://translate.google.com to 3GB (with CanvasBlocker 1.10) and memory would be consumed until the computer completely freezes, and I had to force the restart by using the physical power button. In the CanvasBlocker 1.9 I didn't have issues.

kkapsner commented 7 months ago

Please try canvasblocker-beta-1.10.1.20240405.zip

spodermenpls commented 7 months ago

Please try canvasblocker-beta-1.10.1.20240405.zip

Works again.

spacesynth commented 7 months ago

@kkapsner Thanks for the fast fix, I was able to load your unsigned beta as temporary addon in about:debugging because stable channel (unlike dev,nightly,esr) does not allow to use xpinstall.signatures.required;false now the YouTube issues are fully gone! Hurray!

kkapsner commented 7 months ago

You should be able to install it permanently via https://canvasblocker.kkapsner.de/versions/

spacesynth commented 7 months ago

Thanks for the link to signed betas! This works great. I close the issue now, unless someone still needs it.

spodermenpls commented 7 months ago

@kkapsner The auto-update of your self-hosted versions has some issues, after I installed the latest 1.10.1 version, Firefox immediately tries to "update" to version 1.10 from March 30th, which re-introduces the "CB slows down this site" problem.

kkapsner commented 7 months ago

I know... the version scheme has to be changed for the betas. I think I will create a new alpha tomorrow with a version that prevents this problem.

spodermenpls commented 7 months ago

@kkapsner Is there a real need for a split between "Alpha" and "Beta" versions though?

kkapsner commented 7 months ago

not really... and the split is very fuzzy already...

kkapsner commented 7 months ago

Update for "beta" should work now again.

kkapsner commented 7 months ago

The current beta version is my candidate for 1.10.1 - please test it.