search

kkarpieszuk / wc-price-history

Track Woocommerce Products prices history and display the lowest price in the last 30 days. This plugin allows your WC shop to be compliant with European Commision Directive 98/6/EC Article 6a which specyfies price reduction annoucment policy.
MIT License
6 stars 4 forks source link

Lowest price displayed without tax in spite of WooCommerce settings #34

Closed mziab closed 1 year ago

mziab commented 1 year ago

I've noticed that the lowest price (using the shortcode) is displayed without tax, despite the following WooCommerce tax settings: "Prices entered with tax" -> "No, I will enter prices exclusive of tax" "Display prices in the shop" -> "Including tax" "Display prices during cart and checkout" -> "Including tax"

Behavior: The price is displayed without tax

Expected behavior: The price is displayed with tax included

Relevant package versions: WooCommerce 7.3.0 WC Price History 1.6.1

kkarpieszuk commented 1 year ago

thanks, let me fix this

kkarpieszuk commented 1 year ago

@mziab it is fixed and released as version 1.6.2 ;)

Please go to wp-admin and update the plugin and confirm if it works correctly now.

If you would like to appreciate the fix, please consider leaving 5-star review on plugin's page: https://wordpress.org/support/plugin/wc-price-history/reviews/?filter=5#new-post

mziab commented 1 year ago

@kkarpieszuk There seems to be a regression in 1.6.2:

Fatal error: Uncaught Error: Class 'PriorPrice\Taxes' not found in ANONYMIZED/wp-content/plugins/wc-price-history/app/PriorPrice/Hooks.php:19 Stack trace: #0 ANONYMIZED/wp-content/plugins/wc-price-history/plugin.php(33): PriorPrice\Hooks->register_hooks() #1 ANONYMIZED/wp-admin/includes/plugin.php(2314): include_once('/home/ddd/ftp/w...') #2 ANONYMIZED/wp-admin/plugins.php(192): plugin_sandbox_scrape('wc-price-histor...') #3 {main} thrown in ANONYMIZED/wp-content/plugins/wc-price-history/app/PriorPrice/Hooks.php on line 19

kkarpieszuk commented 1 year ago

sorry for that, I just learned in a hard way wordpress is still using the plugin on the time when it is being upgraded :( sorry that you had to learn it with me

I released 1.6.4, please download it and install

kkarpieszuk commented 1 year ago

wait, it is still wrong... (what a day...)

kkarpieszuk commented 1 year ago

It should be ok now, please download 1.6.4

mziab commented 1 year ago

Thanks, it seems to be working as expected.

kkarpieszuk commented 1 year ago

uff, the fault was completely on my own. I created a new Taxes.php class but I forgot when you upload ne wversion of the plugin to WordPress repository server you have to explicitly mark a new files to be uploaded. That's why I have seen this fixed (I have this file on my comp of course) but you had fatal error (required Taxes.php file was not on wordpress repo).