search

kkawakam / rustyline

Readline Implementation in Rust
https://crates.io/crates/rustyline/
MIT License
1.52k stars 175 forks source link

rustyline break some architecture on linux #731

Closed eatradish closed 10 months ago

eatradish commented 11 months ago

The reason for this is that some of the terminal control constants in termios are wrong in some architectures, specifically at: https://github.com/dcuddeback/termios-rs/pull/37 but it looks like the termios authors don't show up much anymore, rustlyline Is it possible to fix the problem on your own code? The solution is simple: change all variables like termios::VEOF to libc::VEOF

gwenn commented 11 months ago

Maybe we should rollback #717 ?

eatradish commented 11 months ago

Maybe we should rollback #717 ?

Perhaps it could also be maintained by rustyline's author fork a termios? I'm not sure which is the better option

gwenn commented 11 months ago

Maybe we should rollback #717 ?

Perhaps it could also be maintained by rustyline's author fork a termios? I'm not sure which is the better option

I would prefer to put termios-rs behind an optional feature (and keep using nix by default as before). (I suppose that you can activate termios-rs based on OS)

sunfishcode commented 10 months ago

If you're interested, another option would be to use rustix's termios API, which doesn't have the issues of https://github.com/nix-rust/nix/issues/2071 or https://github.com/dcuddeback/termios-rs/pull/37.

gwenn commented 10 months ago

@sunfishcode But possibly rustix specific issues...

gwenn commented 10 months ago

nix termios usages => 702 rustix termios usages => 36

gwenn commented 8 months ago

Version 13.0.0 released.