kkdai / youtube

Download Youtube Video in Golang
MIT License
3.31k stars 429 forks source link

fix: download speed & integrate transcripts #286

Closed Davincible closed 1 year ago

Davincible commented 1 year ago

Description

Fix the download speed. Get ~300+ Mb/s~ full gigabit speed now.

Code is very rough, could use some cleanup. But works for my purposes. Feel free to push to this branch directly to clean up.

All tests pass.

Issues to fix

217 #282

Davincible commented 1 year ago

@corny

Davincible commented 1 year ago

Good catch

denis-kilchichakov commented 1 year ago

Can't wait this PR to be merged - low speed makes this library barely usable :/

pytomtoto commented 1 year ago

nice job

Forsigg commented 1 year ago

Can't wait this PR to be merged - low speed makes this library barely usable :/

Yep, fully agree. I'm already use this fork in my pet project, works great. Download speed has increased greatly. Thanks @Davincible for this fix!

Davincible commented 1 year ago

@corny

corny commented 1 year ago

Thanks a lot for you work! I've just released a new version.