kkdevs / Patchwork

mod
13 stars 1 forks source link

[17v3] Newly added characters never appear and cause null reference hangs on period change #24

Closed ark-royal-91 closed 6 years ago

ark-royal-91 commented 6 years ago

output.log Excerpt:

NullReferenceException: Object reference not set to an instance of an object
  at ActionGame.Chara.AI.CoordinateSetting (ActionGame.ResultInfo aiResult) [0x00000] in <filename unknown>:0 
  at ActionGame.Chara.AI.FirstAction () [0x00000] in <filename unknown>:0 
  at ActionScene+<>c.<SetAllCharaActive>b__133_0 (ActionGame.Chara.NPC npc) [0x00000] in <filename unknown>:0 
  at System.Collections.Generic.List`1[ActionGame.Chara.NPC].ForEach (System.Action`1 action) [0x00000] in <filename unknown>:0 
  at ActionScene.SetAllCharaActive (Boolean isActive) [0x00000] in <filename unknown>:0 
  at ActionGame.Cycle+<MapMove>d__99.MoveNext () [0x00000] in <filename unknown>:0 
  at UniRx.Observable+<WrapEnumerator>d__283.MoveNext () [0x00000] in <filename unknown>:0 

They'll be banished to map 0, and while you can use the inspector to pull them up from map 0 to your current map and even talk to them, they will remain static and inevitably still trigger the hang during the character reloads on next period change.

Characters added to the class as part of creating a new game don't suffer from this error.

Saving then loading after adding characters corrects the problem.

ezdiy commented 6 years ago

Thanks for detailed and on point report. There's now 17v4 which should be fixing this. Note that this is part of game which did change significantly in the DLC so there might be still bugs related to this.