search

kkebo / DevToys.swiftpm

DevToys for iPad (WIP)
MIT License
37 stars 5 forks source link

AllToolsView content doesn't switch to search results when searching once I click the "All tools" row in the sidebar #22

Closed kkebo closed 2 years ago

kkebo commented 2 years ago

Steps to reproduce

  1. Open DevToys for iPad
  2. Click the "All tools" row on the sidebar
  3. Swipe down the sidebar to show the search field
  4. Focus the search field and enter text into it

Expected behaviors

The title of the right column will be "Search results" and will display the search results instead of all tools.

Actual behaviors

The title won't change and all tools will remain visible.

Video

https://user-images.githubusercontent.com/601636/167291557-ca403425-43c8-4d07-b77d-b911c6e44988.MOV

iPad Pro 12.9" 5th generation with Magic Keyboard (iPadOS 15.5 DB 4)

kkebo commented 2 years ago

Probably, this is due to the fact that the NavigationLink of "All tools" is removed throughout searching. The removal of the NavitaionLink means that the changes of searchQuery will not be passed to AllToolsView.