search

kkemple / hwyd

How Was Your Day? Quickly track your ups and downs
37 stars 9 forks source link

Tab bar icon padding + report font #12

Closed rdela closed 6 years ago

rdela commented 6 years ago

closes #4

Have iPhone X + sim screenshots I can add if anyone wants to see them!

kkemple commented 6 years ago

could you add screen shots?

rdela commented 6 years ago

Tab Bar Padding

Before (Today screen):

img_6170-20180318-174840

After (Today screen):

img_6172-20180318-174903

rdela commented 6 years ago

Report screen font

Before:

nothing to report yet before

After:

nothing to report yet after

rdela commented 6 years ago

Report graph paddingVertical

Before from sim w/ inspector up

screen shot 2018-03-18 at 135038

After from sim w/ inspector up

screen shot 2018-03-18 at 135231

Before iPhone X

img_6174-20180318-180559

After iPhone X

img_6175-20180318-180604

kkemple commented 6 years ago

this looks amazing! ❤️

only feedback is can we center title vertically for no reports state, like we do on journal page?

kkemple commented 6 years ago

or should we move journal one up? 🤔

rdela commented 6 years ago

center title vertically for no reports state, like we do on journal page?

Gonna try this one first since it was your 1st intuition, got grabs of current empty and with 1 journal entry for reference in case we change our minds and switch it up later 📸

rdela commented 6 years ago

nü sqreenshawtz! 🤘

empty Reports state

img_6203-20180320-162209

Reports with checkIns.length check set to 2 to preview graph (unchanged)

img_6204-20180320-162218

kkemple commented 6 years ago

amazing!! thanks so much for this! :heart:

kkemple commented 6 years ago

also, i've added you as a collaborator so you can check out this repo now unless you want to continue to work from your fork, up to you!