search

kkemple / primus-webpack-plugin

Build client side primus script and add to build assets 📦⚡
MIT License
7 stars 10 forks source link

Prevent webpack process from hanging #4

Closed Cherry closed 7 years ago

Cherry commented 7 years ago

After initialising Primus, it's never closed or destroyed, so it's still awaiting connections, etc. This fix resolves that, and destroys the Primus instance after it's been utilised, preventing errors with CI builds, etc.

kkemple commented 7 years ago

wow, good call! thanks! we ended up not going with primus so never hit the CI issues

Cherry commented 7 years ago

Thanks very much! Any chance you could push an update to npm, so we don't have to rely on my fork for builds?

Also, purely out of interest, what did you end up using? We're using Primus in production and are enjoying the experience.

kkemple commented 7 years ago

completely forgot to push to npm, will do now!

we actually moved to graphql and use polling where we can or subscriptions in the future if we need it

kkemple commented 7 years ago

just pushed new version to NPM, sorry about that!

Cherry commented 7 years ago

Thanks very much!