search

kkevlar / section-searcher

Project for CSC 308 and 309
1 stars 0 forks source link

Fix code smells in Category class #145

Closed bwlyday closed 5 years ago

bwlyday commented 5 years ago

Remove this unused import 'java.util.List' (line 4)

Replace the type specification in this constructor call with the diamond operator ("<>"). (line 30, generic Category constructor)

The type of the "courses" object should be an interface such as "List" rather than the implementation "ArrayList" (line 33, Category constructor)

Use a StringBuilder instead. (line 44, toString)

The return type of this method should be an interface such as "List" rather than the implementation "ArrayList" (line 58, getCourses)

bwlyday commented 5 years ago

Round 2: Remove this useless assignment; "courses" already holds the assigned value along all execution paths. (line 37, Category constructor)

This branch's code block is the same as the block for the branch on line 77 (line 80, 83, 86, equals method)