search

kkevn / LEDsign

Android application that previews and sends custom designs via Bluetooth to the complementary RGB Arduino circuit.
MIT License
0 stars 0 forks source link

3D Preview Sketch Does Not Update on Reset #19

Open kkevn opened 3 years ago

kkevn commented 3 years ago

Summary: Pressing the Reset button in the toolbar's options menu should immediately clear the 3D preview sketch back to its default state with no effects displaying.

Steps to reproduce:

  1. Navigate to the profile creation page with the 3D preview sketch
  2. Apply any combination of at least one effect
  3. Tap the Reset option in the toolbar's options menu
  4. Observe the 3D preview sketch

Actual result: The 3D preview sketch "saves" the last frame it rendered before being reset, causing it to display part of the just recently cleared effects.

Expected result: The 3D preview sketch should display no effects whatsoever, essentially returning it to its default state.

kkevn commented 3 years ago

This issue has been fixed for when the sketch has no effects in the list to render. However, a similar issue occurs when multiple effects were present and then one changed in some way, such as reordering or removing a single effect.

May require rewrite of how the sketch is rendering effects; bug possibly due to the current method of scanline rendering.