search

kkiermasz / Neron

Swift DSL Auto Layout framework
MIT License
1 stars 0 forks source link

embed(in:) doesn't call translatesAutoresizingMaskIntoConstraints = false #14

Open Gargo opened 10 months ago

kkiermasz commented 10 months ago

Hi @Gargo,

Thank you for submitting this.

Yes, it doesn't. This was by design since add(to:) and all related methods handle it.

It is worth exploring this topic. Could you please provide use cases in which you're missing that feature? As (I assume) there aren't many users of this library, it would be beneficial to understand how people use it.

Gargo commented 10 months ago

@kkiermasz it is unclear why add and embed methods are declared nearby, look similar but the first one performs an essential method call and the second one doesn't. It is also strange when you create a wrapper over the standard library with constraints and don't disable translatesAutoresizingMaskIntoConstraints which may break these constraints.

I often need to write similar things via different ways (and layout is one of them) so I often use random third-party libraries. Unfortunately there a lot of basic unresolved problems with your library so I've already switched to another one.