kkinnear
commented
1 year ago I'm not entirely sure just what you find odd in these examples, but your red boxes certainly give me some clues. If I've guessed wrong, please ask me again.
In the first example, the map is indeed justified, but the let bindings are not. Regardless of what you set for the :max-variance, if the justification doesn't produce something that is deemed "better" than the unjustified output, the justification isn't accepted as the "better" format and isn't used. If the left element of a pair (the local name in this case) takes more than one line, then the justification is not "better" than regular formatting for the bindings. That is independent of the formatting of the map itself, which justifies fine internally.
The second example seemed complex to me until I broke it down a bit, but at least what I see as odd is a result of an interaction between :style :justified and :style :respect-nl. Here it is with just :style :justified-original (which does the :max-variance=1000 thing):
(czprint i273 {:parse-string? true :style :justified-original :width 105})
(defn button
[{:keys [on-press disabled type theme before after haptic-feedback haptic-type on-long-press
on-press-start accessibility-label loading border-radius style],
:or {theme :main, type :primary, haptic-feedback true, border-radius 8, haptic-type :selection}}
children]
(let [theme' (cond disabled :disabled
:else theme)
{:keys [icon-color background-color text-color border-color]} (themes theme')
optional-haptic (fn []
(when haptic-feedback
(haptic/trigger haptic-type)))]
[animation/pressable
(merge {:bg-color background-color,
:border-radius border-radius,
:type type,
:disabled disabled,
:accessibility-label accessibility-label}
(when border-color {:border-color border-color, :border-width 1})
(when on-press
{:on-press (fn [] (optional-haptic) (on-press))})
(when on-long-press
{:on-long-press (fn [] (optional-haptic) (on-long-press))})
(when on-press-start
{:on-press-start (fn [] (optional-haptic) (on-press-start))}))
[rn/view {:style (merge (style-container type) style)}
(when before [rn/view [icons/icon before {:color icon-color}]])
(when loading [rn/view {:style {:position :absolute}} [rn/activity-indicator]])
[rn/view {:style (merge (content-style type) (when loading {:opacity 0}))}
(cond (= type :icon) [icons/icon children {:color icon-color}]
(string? children) [text/text
{:weight :medium, :number-of-lines 1, :style {:color text-color}}
children]
(vector? children) children)]
(when after [rn/view [icons/icon after {:color icon-color}]])]]))You can see that the three let locals are justified.
Here it is with everything above, and :style :respect-nl added:
(czprint i273 {:parse-string? true :style [:justified-original :respect-nl] :width 105})
(defn button
[{:keys [on-press disabled type theme before after
haptic-feedback haptic-type on-long-press on-press-start
accessibility-label loading border-radius style],
:or {theme :main,
type :primary,
haptic-feedback true,
border-radius 8,
haptic-type :selection}}
children]
(let [theme' (cond
disabled :disabled
:else theme)
{:keys [icon-color background-color text-color border-color]}
(themes theme')
optional-haptic (fn []
(when haptic-feedback
(haptic/trigger haptic-type)))]
[animation/pressable
(merge {:bg-color background-color,
:border-radius border-radius,
:type type,
:disabled disabled,
:accessibility-label accessibility-label}
(when border-color
{:border-color border-color,
:border-width 1})
(when on-press
{:on-press (fn []
(optional-haptic)
(on-press))})
(when on-long-press
{:on-long-press (fn []
(optional-haptic)
(on-long-press))})
(when on-press-start
{:on-press-start (fn []
(optional-haptic)
(on-press-start))}))
[rn/view {:style (merge (style-container type) style)}
(when before
[rn/view
[icons/icon before {:color icon-color}]])
(when loading
[rn/view {:style {:position :absolute}}
[rn/activity-indicator]])
[rn/view
{:style (merge (content-style type)
(when loading
{:opacity 0}))}
(cond
(= type :icon)
[icons/icon children {:color icon-color}]
(string? children)
[text/text
{:weight :medium,
:number-of-lines 1,
:style {:color text-color}}
children]
(vector? children)
children)]
(when after
[rn/view
[icons/icon after {:color icon-color}]])]]))You can see that the second local has (themes theme') on the next line. That is because there is a newline after the map (which is the left hand element of the local pair). Thus, it comes out on a new line. And this doesn't break the justification, which is ... interesting. It might possibly be better if there were newlines in the pairs that the justification would be considered "not better" and not happen. But that may or may not be true. I'm going to have to think on that one a bit.
In any case, I hope that this clears up and explains the oddities that you noticed in the output. If not please ask again! Thanks!
yqrashawn
zprint config https://github.com/status-im/status-mobile/pull/14128/commits/817a249994ef212a046304b0e563d2cc5fbe244e#diff-ad67b6e0a11904cfc29b634bde55f00d9961091fb1d34ccdb98e79cd7c2f4febR1-R49
example 1: https://github.com/status-im/status-mobile/pull/14128/commits/9ba1f28dbf14215a39833a34d346dd746d58ce3b#diff-acc2864028c846a967aae52fa52b23048f98d0b5cee98b2e118047f2dbb52171R58-R137
example 2: https://github.com/status-im/status-mobile/pull/14128/commits/f19bf88bb8acb1536482ad4607480498a6881b5c#diff-b95d5dad0bb120bacc3d6495349ebec19ed96bd1c2aba6a3c9ad84bc638bb78cR61-R79