kkinnear
commented
1 year ago An interesting question about the Tonsky's Better Clojure Formatting. Near as I can tell, his rules are what I call "indent only" kinds of rules. That is to say that I don't think his rules every cause the addition of another line. In part because there is no concept of "width" in Tonky's rules, so there would never be a reason to move something onto another line. Or, presumably, move something that was on a subsequent line up to a previous line.
I don't have any examples of the TCBF (Tonsky's Better Clojure Formatting) applied to complex situations. If I take his simple examples off of the web-page you linked me to above, I can exactly reproduce them with the standard :indent-only style. For example:
; i301 is basically the examples off of the TBCF website:
(print i301)
(when something
body)
(defn f [x]
body)
(defn f
[x]
body)
(defn many-args [a b c
d e f]
body)
(defn multi-arity
([x]
body)
([x y]
body))
(let [x 1
y 2]
body)
[1 2 3
4 5 6]
{:key-1 v1
:key-2 v2}
#{a b c
d e f}
; If I use i301 as the input to zprint with :indent-only
(zprint-file-str i301 "" {:style :indent-only})
"(when something\n body)\n\n(defn f [x]\n body)\n\n(defn f\n [x]\n body)\n\n(defn many-args [a b c\n d e f]\n body)\n\n(defn multi-arity\n ([x]\n body)\n ([x y]\n body))\n\n(let [x 1\n y 2]\n body)\n\n[1 2 3\n 4 5 6]\n\n{:key-1 v1\n :key-2 v2}\n\n#{a b c\n d e f}\n"
zprint.core=> (print *1)
(when something
body)
(defn f [x]
body)
(defn f
[x]
body)
(defn many-args [a b c
d e f]
body)
(defn multi-arity
([x]
body)
([x y]
body))
(let [x 1
y 2]
body)
[1 2 3
4 5 6]
{:key-1 v1
:key-2 v2}
#{a b c
d e f}They really are the same:
zprint.core=> (zprint-file-str i301 "" {:style :indent-only})
"(when something\n body)\n\n(defn f [x]\n body)\n\n(defn f\n [x]\n body)\n\n(defn many-args [a b c\n d e f]\n body)\n\n(defn multi-arity\n ([x]\n body)\n ([x y]\n body))\n\n(let [x 1\n y 2]\n body)\n\n[1 2 3\n 4 5 6]\n\n{:key-1 v1\n :key-2 v2}\n\n#{a b c\n d e f}\n"
zprint.core=> (= i301 *1)
trueWill the zprint :indent-only style also reproduce what the TBCF style mandates in more complex situations? Hard to say, but it is entirely possible that it will. The zprint :indent-only style does not use the :fn-map and does not change formatting based on the function or macro being formatted. Which is what TBCF mandates. It also means that the :indent-only style will not wake up and do something odd with some function because it doesn't know about different functions.
I just reviewed zprint's :indent-only documentation, and I noticed that I used mostly the examples from the TBCF page there. I also remember that there was some discussion about aligning things that were already aligned, which zprint does using :style :indent-only. I don't remember where this discussion occurred, but I do remember reading it. You can see it in operation below:
zprint.core=> (print i301a)
(or (condition-a)
(condition-b))
nil
zprint.core=> (czprint i301a {:parse-string? true :style :indent-only})
(or (condition-a)
(condition-b))
nil
zprint.core=> (print i301b)
(or (condition-a)
(condition-b))
nil
zprint.core=> (czprint i301b {:parse-string? true :style :indent-only})
(or (condition-a)
(condition-b))
nil
zprint.core=> (print i301c)
(or (condition-a)
(condition-b)
(condition-c))
nil
zprint.core=> (czprint i301c {:parse-string? true :style :indent-only})
(or (condition-a)
(condition-b)
(condition-c))
nil
zprint.core=> (print i301d)
(or (condition-a)
(condition-b)
(condition-c))
nil
zprint.core=> (czprint i301d {:parse-string? true :style :indent-only})
(or (condition-a)
(condition-b)
(condition-c))If you don't like the way that :style :indent-only detects the alignment of the third element in a list relative to the second element of a list and replicates that alignment for the rest of the list, you can disable it like this:
zprint.core=> (czprint i301c {:parse-string? true :style :indent-only})
(or (condition-a)
(condition-b)
(condition-c))
nil
zprint.core=> (czprint i301c {:parse-string? true :style :indent-only :list {:indent-only-style :none}})
(or (condition-a)
(condition-b)
(condition-c))I hope that :style :indent-only meets your needs. Let me know how it goes for you if you can, as I would like to know your response to whether or not this meets your needs. Thanks!
ned-at-obrizum
radovanne
Hey, Neovim users usually have a hard time setting up formatting for their needs, and some of us are not using community standard formatting.. Is it possible to add Better Clojure Formatting from Tonsky as one of the styles that can be applied? https://tonsky.me/blog/clojurefmt/ Thanks.