add margin loss function from scone

kkirchheim / pytorch-ood

👽 Out-of-Distribution Detection with PyTorch

https://pytorch-ood.readthedocs.io/

Apache License 2.0

256 stars 24 forks source link

add margin loss function from scone #75

Closed amztc34283 closed 2 months ago

amztc34283 commented 2 months ago

Added loss function: EnergyMarginLoss in src/pytorch_ood/loss/scone.py Added functions on utils.py: evaluate_classification_loss_training, evaluate_energy_logistic_loss Added example on examples/loss/supervised/scone.py

kkirchheim commented 2 months ago

Thank you for the implementation. Could you maybe do the following adjustments?

add some basic test, e.g. a forward and a backwards pass through the loss
add some documentation to the parameters of the loss
move the evaluate_classification_loss_training from the general utils to scone.py, as it is only used there?

amztc34283 commented 2 months ago

Let me know if there is anything else you want me to fix!