search

kkla320 / GaugeProgressViewStyle

GaugeProgressViewStyle adds the Apple Watch gauge view to iOS.
MIT License
36 stars 1 forks source link

Error regarding the Angles #10

Closed MunirehHosseinzada closed 2 years ago

MunirehHosseinzada commented 2 years ago

Hi. I have added this package to my project. But after adding this package I got these errors and tried to use .gauge style for my progressView, I got these errors.

1- Argument type 'SwiftUI.Angle' does not conform to expected type 'Trigonometry.Angle' (CGPoint+init.swift) 2- Type 'ProgressViewStyle' has no member 'gauge' (ContentView.swift)

kkla320 commented 2 years ago

Hi, Can you please tell me for what platform you try to build? I will try to reproduce the bug on my system as well and try to fix is as fast as possible.

kkla320 commented 2 years ago

I found the issue and fixed it in Version 1.0.1

mattgreen commented 2 years ago

I am still seeing this happen, unfortunately. Building an iOS app targeting 15.4, I have Trigonometry 1.0.1 and GaugeProgressViewStyle 1.0.1.

Looking at the fix, I'm confused as to what the intent is with this line of code: 

#if canImport(SwiftUI) && (!os(iOS) || arch(arm64))

Should the file be ignored entirely on iOS? If so, then the following @available line is misleading. However, the usage in the library seems to suggest that a SwiftUI.Angle is expected to conform to the Trigonometry.Angle as it is used.

kkla320 commented 2 years ago

I`ll reopen the issue and have a look again. Thanks for pointing it out again.

gabehoffman commented 2 years ago

I'm getting this error as well now. I can build to Any iOS Device (arm64) but if I target the simulator for an iPad it breaks. This wasn't an issue a couple of weeks ago.

kkla320 commented 2 years ago

I created a new branch with a potential fix. If you @gabehoffman and @mattgreen could have a look, I would appreciate the help. The fix is on branch fix/#10_Angles.

kkla320 commented 2 years ago

I merged my fix and created a new release 1.0.2. With this release you should be able to compile the project again.