kkonteh97 / SwiftOBD2

The versatile OBD2 toolkit for Swift developers. Diagnose, explore, and build custom vehicle apps with ease. Includes an emulator for streamlined prototyping.
MIT License
45 stars 8 forks source link

Hi. Problem configuring #16

Open acetuning opened 5 months ago

acetuning commented 5 months ago

Hi

I did use your example app but XcodeGen always had problem with dependency never could find the git repo of SwiftOBD2. I use latest code and ios17.

Any way of advice please? Lov the project but definitely would prefer to start from sample app then from scratch

Edit: solved

kkonteh97 commented 5 months ago

Thank mate. I'm still looking into this issue. Did you get it working by adding it as a local package.

acetuning commented 5 months ago

Exactly. I did create it a new project and added files and packages locally. It works connects to car reads some live data but. Not much. Have u think before maybe about uds protocol for it?

Also one more Q :)

How to alert connection to use Wi-Fi? I’m sure I would get there, but since we talk ;)

Very happy to hear from you. My name is Jakub by the way

W dniu śr., 17.04.2024 o 17:44 Kemo Konteh @.***> napisał(a):

Thank mate. I'm still looking into this issue. Did you get it working by adding it as a local package.

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2061604823, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRARZMNQCDIP2VMNPGW3Y52KENAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGYYDIOBSGM . You are receiving this because you authored the thread.Message ID: @.***>

acetuning commented 5 months ago

It does connect to the car but failed to read DTC it’s crashing. Also it does work on Mercedes GLOM642 from 2009 and on fourth focus 2013 1.6 diesel sid 807. But failed to connect to ECU on md1 for Focus 2021 model

W dniu śr., 17.04.2024 o 17:47 VetitumSoft llc @.***> napisał(a):

Exactly. I did create it a new project and added files and packages locally. It works connects to car reads some live data but. Not much. Have u think before maybe about uds protocol for it?

Also one more Q :)

How to alert connection to use Wi-Fi? I’m sure I would get there, but since we talk ;)

Very happy to hear from you. My name is Jakub by the way

W dniu śr., 17.04.2024 o 17:44 Kemo Konteh @.***> napisał(a):

Thank mate. I'm still looking into this issue. Did you get it working by adding it as a local package.

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2061604823, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRARZMNQCDIP2VMNPGW3Y52KENAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGYYDIOBSGM . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 5 months ago

I will check it out out to see what the bugs are, unfortunately I only have access to a Nissan Altima to test it on. if you have access to various car and want to help improve the repo I would really appreciate it. I don't know much about the uds protocol but I am still learning some of the reading material gets expensive. but if you have experience with any input would be appreciated. does it provide any error codes?

acetuning commented 5 months ago

Yes, I’m very happy to participate. I have built on Python before I only started swift yesterday literally. If I will find out something, I will keep you posted as well and if you wanna test, On more cars, I’m your person to go. Sorry if I sound like dyslexic, I’m on motorway driving 😂

W dniu śr., 17.04.2024 o 17:57 Kemo Konteh @.***> napisał(a):

It does connect to the car but failed to read DTC it’s crashing. Also it does work on Mercedes GLOM642 from 2009 and on fourth focus 2013 1.6 diesel sid 807. But failed to connect to ECU on md1 for Focus 2021 model W dniu śr., 17.04.2024 o 17:47 VetitumSoft llc @.

> napisał(a): … <#m1574492123638093541> Exactly. I did create it a new project and added files and packages locally. It works connects to car reads some live data but. Not much. Have u think before maybe about uds protocol for it? Also one more Q :) How to alert connection to use Wi-Fi? I’m sure I would get there, but since we talk ;) Very happy to hear from you. My name is Jakub by the way W dniu śr., 17.04.2024 o 17:44 Kemo Konteh @.> napisał(a): > Thank mate. I'm still looking into this issue. > Did you get it working by adding it as a local package. > > — > Reply to this email directly, view it on GitHub > <#16 (comment) https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2061604823>,

or unsubscribe > https://github.com/notifications/unsubscribe-auth/AS6JRARZMNQCDIP2VMNPGW3Y52KENAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGYYDIOBSGM . > You are receiving this because you authored the thread.Message ID: > @.***> >

I will check it out out to see what the bugs are, unfortunately I only have access to a Nissan Altima to test it on. if you have access to various car and want to help improve the repo I would really appreciate it. I don't know much about the uds protocol but I am still learning some of the reading material gets expensive. but if you have experience with any input would be appreciated. does it provide any error codes?

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2061638968, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAUESXGRPZLEIHSBBNDY52LVZAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGYZTQOJWHA . You are receiving this because you authored the thread.Message ID: @.***>

acetuning commented 5 months ago

Actualy another Q of u don’t mind…

Settings in app is not visible

W dniu śr., 17.04.2024 o 18:00 VetitumSoft llc @.***> napisał(a):

Yes, I’m very happy to participate. I have built on Python before I only started swift yesterday literally. If I will find out something, I will keep you posted as well and if you wanna test, On more cars, I’m your person to go. Sorry if I sound like dyslexic, I’m on motorway driving 😂

W dniu śr., 17.04.2024 o 17:57 Kemo Konteh @.***> napisał(a):

It does connect to the car but failed to read DTC it’s crashing. Also it does work on Mercedes GLOM642 from 2009 and on fourth focus 2013 1.6 diesel sid 807. But failed to connect to ECU on md1 for Focus 2021 model W dniu śr., 17.04.2024 o 17:47 VetitumSoft llc @.

> napisał(a): … <#m_7580092358717844013_m1574492123638093541> Exactly. I did create it a new project and added files and packages locally. It works connects to car reads some live data but. Not much. Have u think before maybe about uds protocol for it? Also one more Q :) How to alert connection to use Wi-Fi? I’m sure I would get there, but since we talk ;) Very happy to hear from you. My name is Jakub by the way W dniu śr., 17.04.2024 o 17:44 Kemo Konteh @.> napisał(a): > Thank mate. I'm still looking into this issue. > Did you get it working by adding it as a local package. > > — > Reply to this email directly, view it on GitHub > <#16 (comment) https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2061604823>,

or unsubscribe > https://github.com/notifications/unsubscribe-auth/AS6JRARZMNQCDIP2VMNPGW3Y52KENAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGYYDIOBSGM . > You are receiving this because you authored the thread.Message ID: > @.***> >

I will check it out out to see what the bugs are, unfortunately I only have access to a Nissan Altima to test it on. if you have access to various car and want to help improve the repo I would really appreciate it. I don't know much about the uds protocol but I am still learning some of the reading material gets expensive. but if you have experience with any input would be appreciated. does it provide any error codes?

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2061638968, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAUESXGRPZLEIHSBBNDY52LVZAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGYZTQOJWHA . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 5 months ago

lemme add that really quick

kkonteh97 commented 5 months ago

check the latest commit

acetuning commented 5 months ago

nope wont work. build failed [image: image.png]

śr., 17 kwi 2024 o 20:10 Kemo Konteh @.***> napisał(a):

check the latest commit

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2061915966, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAQGOENVSLRHBPJDTRLY523JXAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRHEYTKOJWGY . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 5 months ago

I can't see the screenshot

acetuning commented 5 months ago

Please check now.

śr., 17 kwi 2024 o 20:33 Kemo Konteh @.***> napisał(a):

I can't see the screenshot

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2061961319, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAU5LSY3NOQODYBWGM3Y5257NAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRHE3DCMZRHE . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 5 months ago

Still nothing

acetuning commented 5 months ago

ive added public ennum to decoders: import Foundation

public enum MeasurementUnits: String, Codable, CaseIterable {

case metric = "Metric"

case imperial = "Imperial"

} and it built with settings active ok now can see wifi bt settings but there is no real implementation of those isnt it?

śr., 17 kwi 2024 o 20:41 Kemo Konteh @.***> napisał(a):

Still nothing

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2061973923, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAQRE2VWYXUU6ZSABPLY5264ZAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRHE3TGOJSGM . You are receiving this because you authored the thread.Message ID: @.***>

acetuning commented 5 months ago

ok im doing this from mac not iphone...

LSPrefs: could not find untranslocated node for <FSNode 0x6000006bc1c0> { isDir = ?, path = '/private/var/folders/5r/jy2pgtnj7mgcp36k5z5g9cr00000gn/X/31627F5D-EB91-5C7C-8C7B-BDF88B4A97F3/d/Wrapper/SwiftOBD2App.app' }, proceeding on the assumption it is not translocated: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted"

LSPrefs: could not find untranslocated node for <FSNode 0x6000006bc1c0> { isDir = ?, path = '/private/var/folders/5r/jy2pgtnj7mgcp36k5z5g9cr00000gn/X/31627F5D-EB91-5C7C-8C7B-BDF88B4A97F3/d/Wrapper/SwiftOBD2App.app' }, proceeding on the assumption it is not translocated: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted"

LSPrefs: could not find untranslocated node for <FSNode 0x6000006bc1c0> { isDir = ?, path = '/private/var/folders/5r/jy2pgtnj7mgcp36k5z5g9cr00000gn/X/31627F5D-EB91-5C7C-8C7B-BDF88B4A97F3/d/Wrapper/SwiftOBD2App.app' }, proceeding on the assumption it is not translocated: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted"

LSPrefs: could not find untranslocated node for <FSNode 0x6000006bc1c0> { isDir = ?, path = '/private/var/folders/5r/jy2pgtnj7mgcp36k5z5g9cr00000gn/X/31627F5D-EB91-5C7C-8C7B-BDF88B4A97F3/d/Wrapper/SwiftOBD2App.app' }, proceeding on the assumption it is not translocated: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted"

Bluetooth is On.

Connecting to: 24DIAG

Connected to peripheral: 24DIAG

Discovered service: FFF0

Protocol 6 found

The operation couldn’t be completed. (SwiftOBD2.BLEManagerError error 5.)

The operation couldn’t be completed. (SwiftOBD2.BLEManagerError error 5.)

The operation couldn’t be completed. (SwiftOBD2.BLEManagerError error 5.)

The operation couldn’t be completed. (SwiftOBD2.BLEManagerError error 5.)

The operation couldn’t be completed. (SwiftOBD2.BLEManagerError error 5.)

The operation couldn’t be completed. (SwiftOBD2.BLEManagerError error 5.)

The operation couldn’t be completed. (SwiftOBD2.BLEManagerError error 5.)

The operation couldn’t be completed. (SwiftOBD2.BLEManagerError error 5.)

The operation couldn’t be completed. (SwiftOBD2.BLEManagerError error 5.)

The operation couldn’t be completed. (SwiftOBD2.BLEManagerError error 5.)

thats on dtc scan attempt...

śr., 17 kwi 2024 o 20:43 VetitumSoft llc @.***> napisał(a):

ive added public ennum to decoders: import Foundation

public enum MeasurementUnits: String, Codable, CaseIterable {

case metric = "Metric"

case imperial = "Imperial"

} and it built with settings active ok now can see wifi bt settings but there is no real implementation of those isnt it?

śr., 17 kwi 2024 o 20:41 Kemo Konteh @.***> napisał(a):

Still nothing

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2061973923, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAQRE2VWYXUU6ZSABPLY5264ZAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRHE3TGOJSGM . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 5 months ago

I just fixed the Xcodegen and the error. I'll add loggers in a little bit so we can see the error you are getting

acetuning commented 5 months ago

Very nice keep me posted. I’m very happy to help on this project.

W dniu śr., 17.04.2024 o 21:14 Kemo Konteh @.***> napisał(a):

I just fixed the Xcodegen and the error. I'll add loggers in a little bit so we can see the error you are getting

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2062026662, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAQGSCQO3BEIXQUCUGTY53CYFAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSGAZDMNRWGI . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 5 months ago

I just add a logger you can try updating the package let me know where is logs are.

acetuning commented 5 months ago

Nah. It does connects to car but won’t read dtcs app crashing always

W dniu czw., 18.04.2024 o 02:07 Kemo Konteh @.***> napisał(a):

I just add a logger you can try updating the package let me know where is logs are.

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2062754276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAXXGMFXRQ3DRT4IT5LY54FE7AVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSG42TIMRXGY . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 5 months ago

What are the logs you are getting? if it in bluetooth or wifi?

acetuning commented 5 months ago

I did only build the app and try on the car Wi-Fi won’t connect. Bluetooth connected can read PID but won’t read DTC. The app is crashing and I haven’t checked any logs yet. Need to connect iPhone to Mac but I will be able to do it a little bit later on probably

W dniu czw., 18.04.2024 o 17:30 Kemo Konteh @.***> napisał(a):

What are the logs you are getting? if it in bluetooth or wifi?

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2064244274, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAXENUROJ2QEWXSUACLY57RI7AVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRUGI2DIMRXGQ . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 5 months ago

for wifi I need to include the instructions you currently have to go into your wifi settings and connect to the device first

acetuning commented 5 months ago

Ofcorse i dont thx it did connect to elm but not to car

W dniu czw., 18.04.2024 o 17:35 Kemo Konteh @.***> napisał(a):

for wifi I need to include the instructions you currently have to go into your wifi settings and connect to the device first

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2064263112, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAQT2LB64N6RUCHVPHLY57R2XAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRUGI3DGMJRGI . You are receiving this because you authored the thread.Message ID: @.***>

acetuning commented 5 months ago

Can I have your email please I would like to attach you a video but it says size is too large for git extension

W dniu czw., 18.04.2024 o 18:14 VetitumSoft llc @.***> napisał(a):

W dniu czw., 18.04.2024 o 17:35 VetitumSoft llc @.***> napisał(a):

Ofcorse i dont thx it did connect to elm but not to car

W dniu czw., 18.04.2024 o 17:35 Kemo Konteh @.***> napisał(a):

for wifi I need to include the instructions you currently have to go into your wifi settings and connect to the device first

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2064263112, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAQT2LB64N6RUCHVPHLY57R2XAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRUGI3DGMJRGI . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 5 months ago

kkonteh97@gmail.com

acetuning commented 5 months ago

Sory I’ve emailed from my work email @.***

W dniu czw., 18.04.2024 o 18:18 Kemo Konteh @.***> napisał(a):

@.***

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2064418573, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAUV2KIQ45ANN77AWUDY57W5DAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRUGQYTQNJXGM . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 5 months ago

it was an issue with the way I was slicing an array, should be fixed now.

acetuning commented 4 months ago

hi.

got small issue not sure where to look for problems.

2 cars. ford focus 2013 and 2020 one is sid807 other md1 ecu.

it does all to old one but wont connect to new one. couldnt log it iot should use same protocol case .protocol6: return "6: ISO 15765-4 CAN (11 bit ID,500 Kbaud)" i tested in other app and this protocol is compatible with this car but it just wont connect to ecu. it always give error ble manager error 8

czw., 18 kwi 2024 o 19:55 Kemo Konteh @.***> napisał(a):

it was an issue with the way I was slicing an array, should be fixed now.

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2064750078, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAR6S32IZ6XBZRSDVWLY6ACHHAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRUG42TAMBXHA . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 4 months ago

in CustomTabNavigator > CustomTabBarView.swift set the preferedProtocol to .protocol6 and see if that works

 private func connectButtonAction() {
        Task {
            guard !isLoading else {
                return
            }
            self.isLoading = true
            let notificationFeedback = UINotificationFeedbackGenerator()
            let impactFeedback = UIImpactFeedbackGenerator(style: .medium)
            impactFeedback.prepare()
            notificationFeedback.prepare()
            impactFeedback.impactOccurred()

            var vehicle = garage.currentVehicle ?? garage.newVehicle()

            do {
                self.statusMessage = "Initializing OBD Adapter (BLE)"
                toggleDisplayType(to: .halfScreen)

                vehicle.obdinfo =  try await obdService.startConnection(preferedProtocol: .protocol6)
acetuning commented 4 months ago

hi.

have you got a ful llsit of commands supported ?

pon., 22 kwi 2024 o 21:41 Kemo Konteh @.***> napisał(a):

in CustomTabNavigator > CustomTabBarView.swift set the preferedProtocol to .protocol6 and see if that works

private func connectButtonAction() { Task { guard !isLoading else { return } self.isLoading = true let notificationFeedback = UINotificationFeedbackGenerator() let impactFeedback = UIImpactFeedbackGenerator(style: .medium) impactFeedback.prepare() notificationFeedback.prepare() impactFeedback.impactOccurred()

        var vehicle = garage.currentVehicle ?? garage.newVehicle()

        do {
            self.statusMessage = "Initializing OBD Adapter (BLE)"
            toggleDisplayType(to: .halfScreen)

            vehicle.obdinfo =  try await obdService.startConnection(preferedProtocol: .protocol6)

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2070798501, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRASXH5M5SRHZ47WQ7KLY6VRVDAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZQG44TQNJQGE . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 4 months ago

Sources/SwiftOBD2/commands.swift has all the commands but I send 0100 to get the list of supported pids for the vehicle.

acetuning commented 3 months ago

Hi brother, how are you? I have a question to you. I am working on application myself. It’s not really usual diagnostic application but more like a certain Info Extraction and they’re running into small problem with Wi-Fi connection. Bluetooth 50 working perfectly on iPhone 11 and 14 which I have to test. But on Wi-Fi, I have a problem im keep geting this just run out of ideas…. SWIFT TASK CONTINUATION MISUSE: connectAsync(timeout:) leaked its continuation! after conectio nattemp

Is there any chance you can advise on that?

Thanks Jacob

W dniu czw., 30.05.2024 o 18:46 Kemo Konteh @.***> napisał(a):

Closed #16 https://github.com/kkonteh97/SwiftOBD2/issues/16 as completed.

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#event-12988959411, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAQWFVLPKRRWG3SM7CDZE5JVXAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHE4DQOJVHE2DCMI . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 3 months ago

can you provide me with the logs? I'll take a look at It and let you know what I find.

acetuning commented 3 months ago

Disconnected from OBD

SWIFT TASK CONTINUATION MISUSE: connectAsync(timeout:) leaked its continuation!

XPC connection invalid

Failed to connect: An error occurred with the OBD service: The operation couldn’t be completed. (SwiftOBD2.OBDServiceError error 0.)

Reconnect attempt 1 of 5...

Attempting to connect to OBD...

niedz., 2 cze 2024 o 18:23 Kemo Konteh @.***> napisał(a):

can you provide me with the logs? I'll take a look at It and let you know what I find.

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2143922817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRARU73R3AHALBQK7RX3ZFNBH3AVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTHEZDEOBRG4 . You are receiving this because you authored the thread.Message ID: @.***>

acetuning commented 3 months ago

Also nwerror 89 from swift

W dniu niedz., 2.06.2024 o 18:53 VetitumSoft llc @.***> napisał(a):

Disconnected from OBD

SWIFT TASK CONTINUATION MISUSE: connectAsync(timeout:) leaked its continuation!

XPC connection invalid

Failed to connect: An error occurred with the OBD service: The operation couldn’t be completed. (SwiftOBD2.OBDServiceError error 0.)

Reconnect attempt 1 of 5...

Attempting to connect to OBD...

niedz., 2 cze 2024 o 18:23 Kemo Konteh @.***> napisał(a):

can you provide me with the logs? I'll take a look at It and let you know what I find.

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2143922817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRARU73R3AHALBQK7RX3ZFNBH3AVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTHEZDEOBRG4 . You are receiving this because you authored the thread.Message ID: @.***>

acetuning commented 3 months ago

Is there any trick Why iPhone can connect to device But will not connect to the car? 4.0 LE works, WiFi wont work, by 5.0 wont work

W dniu niedz., 2.06.2024 o 19:04 VetitumSoft llc @.***> napisał(a):

Also nwerror 89 from swift

W dniu niedz., 2.06.2024 o 18:53 VetitumSoft llc @.***> napisał(a):

Disconnected from OBD

SWIFT TASK CONTINUATION MISUSE: connectAsync(timeout:) leaked its continuation!

XPC connection invalid

Failed to connect: An error occurred with the OBD service: The operation couldn’t be completed. (SwiftOBD2.OBDServiceError error 0.)

Reconnect attempt 1 of 5...

Attempting to connect to OBD...

niedz., 2 cze 2024 o 18:23 Kemo Konteh @.***> napisał(a):

can you provide me with the logs? I'll take a look at It and let you know what I find.

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2143922817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRARU73R3AHALBQK7RX3ZFNBH3AVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTHEZDEOBRG4 . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 3 months ago

I am working on the fix for the wifi and only logs will give me an idea on why the connection to the car fails.

acetuning commented 3 months ago

That’s the only logs I’m geting

W dniu wt., 4.06.2024 o 14:21 Kemo Konteh @.***> napisał(a):

I am working on the fix for the wifi and only logs will give me an idea on why the connection to the car fails.

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2147398406, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRATJ2GRA2IQBZDIIVQTZFWWL3AVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXGM4TQNBQGY . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 3 months ago

I meant for the 5.0 le device what brand adapter is it?.

acetuning commented 3 months ago

Used those: KONNWEI KW903 Elm327 V1.5 Pic18F25K80 Chip OBD2 automatyczny czujnik z Bluetooth 5.0

Tried also v906

BLE works charm

WiFi wont Conect

W dniu wt., 4.06.2024 o 14:25 Kemo Konteh @.***> napisał(a):

I meant for the 5.0 le device what brand adapter is it?.

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2147406050, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAXI4ALAZVKXIY6HBX3ZFWW2DAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXGQYDMMBVGA . You are receiving this because you authored the thread.Message ID: @.***>

acetuning commented 3 months ago

on wifi i use Vlink and got this: nw_socket_handle_socket_event [C2:1] Socket SO_ERROR [9: Bad file descriptor]

nw_socket_get_input_frames [C2:1] recvmsg(fd 4, 1024 bytes) [57: Socket is not connected]

nw_protocol_socket_reset_linger [C2:1] setsockopt SO_LINGER failed [22: Invalid argument]

Connection failed: POSIXErrorCode(rawValue: 57): Socket is not connected

here is my wifi managerimport Foundation

import Network

import OSLog

protocol CommProtocol {

*func* sendCommand(_ command: String) *async* *throws* -> [String]

*func* disconnectPeripheral()

*func* connectAsync(timeout: TimeInterval) *async* *throws*

*var* connectionStatePublisher: Published<ConnectionState>.Publisher {

get }

*var* obdDelegate: OBDServiceDelegate? { *get* *set* }

}

enum CommunicationError: Error {

*case* invalidData

*case* errorOccurred(Error)

}

class WifiManager: CommProtocol {

*let* logger = Logger(subsystem: Bundle.main.bundleIdentifier ?? "

com.example.app", category: "wifiManager")

*var* obdDelegate: OBDServiceDelegate?

@Published *var* connectionState: ConnectionState = .disconnected

*var* connectionStatePublisher: Published<ConnectionState>.Publisher {

$connectionState }

*var* tcp: NWConnection?

*func* connectAsync(timeout: TimeInterval) *async* *throws* {

    logger.info("Attempting to connect with timeout: \(timeout)

seconds.")

    *let* host = NWEndpoint.Host("192.168.0.10")

    *guard* *let* port = NWEndpoint.Port(rawValue: 35000) *else* {

        *throw* CommunicationError.invalidData

    }

    tcp = NWConnection(host: host, port: port, using: .tcp)

    tcp?.stateUpdateHandler = { newState *in*

        *switch* newState {

        *case* .ready:

            *self*.logger.info("Connected to Wi-Fi adapter")

            *self*.connectionState = .connectedToAdapter

        *case* *let* .waiting(error):

            *self*.logger.warning("Connection waiting: \(error)")

        *case* *let* .failed(error):

            *self*.logger.error("Connection failed: \(error)")

            *self*.connectionState = .disconnected

        *default*:

            *break*

        }

    }

    tcp?.start(queue: .main)

    *try* *await* withCheckedThrowingContinuation { (continuation:

CheckedContinuation<Void, Error>) in

        *let* deadline = DispatchTime.now() + timeout

        DispatchQueue.main.asyncAfter(deadline: deadline) {

            *if* *self*.connectionState == .disconnected {

                continuation.resume(throwing: CommunicationError.

invalidData)

            } *else* {

                continuation.resume(returning: ())

            }

        }

    }

}

*func* sendCommand(_ command: String) *async* *throws* -> [String] {

    *guard* *let* data = "\(command)\r".data(using: .ascii) *else* {

        *throw* CommunicationError.invalidData

    }

    logger.info("Sending: \(command)")

    *return* *try* *await* withCheckedThrowingContinuation {

(continuation: CheckedContinuation<[String], Error>) in

        *self*.tcp?.send(content: data, completion: .contentProcessed {

error in

            *if* *let* error = error {

                *self*.logger.error("Error sending data: \(error)")

                continuation.resume(throwing: error)

            }

            *self*.tcp?.receive(minimumIncompleteLength: 1,

maximumLength: 500, completion: { data, , , error in

                *if* *let* error = error {

                    *self*.logger.error("Error receiving data: \(error)"

)

                    continuation.resume(throwing: error)

                    *return*

                }

                *guard* *let* response = data, *let* string = String(

data: response, encoding: .utf8) else {

                    continuation.resume(throwing: CommunicationError.

invalidData)

                    *return*

                }

                *if* string.contains(">") {

                    *self*.logger.info("Received response: \(string)")

                    *var* lines = string

                        .components(separatedBy: .newlines)

                        .filter { !$0.trimmingCharacters(in: .

whitespacesAndNewlines).isEmpty }

                    lines.removeLast()

                    continuation.resume(returning: lines)

                }

            })

        })

    }

}

*func* disconnectPeripheral() {

    logger.info("Disconnecting from Wi-Fi adapter")

    tcp?.cancel()

    connectionState = .disconnected

}

}

wt., 4 cze 2024 o 14:26 VetitumSoft llc @.***> napisał(a):

Used those: KONNWEI KW903 Elm327 V1.5 Pic18F25K80 Chip OBD2 automatyczny czujnik z Bluetooth 5.0

Tried also v906

BLE works charm

WiFi wont Conect

W dniu wt., 4.06.2024 o 14:25 Kemo Konteh @.***> napisał(a):

I meant for the 5.0 le device what brand adapter is it?.

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2147406050, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAXI4ALAZVKXIY6HBX3ZFWW2DAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXGQYDMMBVGA . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 3 months ago

I will check it out tonight with I'm off work

acetuning commented 3 months ago

Hi man.

May I ask you little explanation?

When reading live data on app.... why some cars can provide 2 at same time? like rpm and say rai pressure or any other. but some only return 1 and other ignoring?

mb gl 2009 diesel edc17 can return more pids focus 1.6 diesel 2013 also bw x6 40d 2023 no prob

skoda superb renault traffic audi a7

mostly petrol once only can return 1 at the time ignoring second one.

trying something like this: self.obdService. startContinuousUpdates([.mode1(.rpm), .mode1(.fuelRate)])

then it gives me in log back rpm and fuel rate on top cars merc focus etc but on lets say petrol en gines just rpm

or if like this: self.obdService.startContinuousUpdates([.mode1(. fuelRate), .mode1(.rpm)]) gives me on top cars all info but on petrol just fuelrate and ignore other

wt., 4 cze 2024 o 21:37 Kemo Konteh @.***> napisał(a):

I will check it out tonight with I'm off work

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2148272389, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAQVHAQI7PSUQEX67FDZFYJRFAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBYGI3TEMZYHE . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 3 months ago

sorry for the late response had to get away for a while, sometimes you get 2 response because there are multiple ecu's responding to the request mainly the engine and transmission, you can tell which is which by the header. I am still fleshing out the multi ecu support so you can specify with you request which ecu you want.

acetuning commented 3 months ago

Hi thanks for answer man.

Hold on so I understand well.

Keep in mind my intention is to get 1 response with 2 pids At same time. I want just 2 pids of engine ecu only for constant monitoring. So you say possibly error is that im geting 1 response because response is coming from say transmission instead of engine?

W dniu sob., 15.06.2024 o 23:29 Kemo Konteh @.***> napisał(a):

sorry for the late response had to get away for a while, sometimes you get 2 response because there are multiple ecu's responding to the request mainly the engine and transmission, you can tell which is which by the header. I am still fleshing out the multi ecu support so you can specify with you request which ecu you want.

— Reply to this email directly, view it on GitHub https://github.com/kkonteh97/SwiftOBD2/issues/16#issuecomment-2170877229, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS6JRAQAC24LM4YIQM4GBMDZHSW2PAVCNFSM6AAAAABGK73JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZQHA3TOMRSHE . You are receiving this because you authored the thread.Message ID: @.***>

kkonteh97 commented 3 months ago

Nope the engine ecu always responses to supported pids sometimes so does the transmission.

IvanIvanovScaleFocus commented 2 weeks ago

Hello, @kkonteh97. I am an iOS developer interested on building an app for personal testing on my own Audi A6 C6 2007. I found your great library. You have done a great job, man! I have Elm327 OBD2 WiFi adapter but cannot connect to the car over wifi. I tried out your sample app and also have built my own using your documentation. I am able to connect to the adapter but cant connect to the ecu. I saw previous comments here with the same issue and wanted to ask you if you have any idea or fix for this? Thanks a lot for your work!

kkonteh97 commented 2 weeks ago

hey thank you I am glad you found the library helpful. does it provide logs for the command it's sending the the response. also is it finding the protocol

IvanIvanovScaleFocus commented 2 weeks ago

Only this kind of logs: Sending: 010C0D SWIFT TASK CONTINUATION MISUSE: sendCommand (_:) leaked its continuation!

kkonteh97 commented 2 weeks ago

I just pushed a fix I'm testing it out but seems to be working so far @acetuning @IvanIvanovScaleFocus

IvanIvanovScaleFocus commented 1 week ago

Great! Will test it out later today! Thanks a lot!