search

kkortes / leaf

Google Material Design Theme
285 stars 42 forks source link

Consider renaming CSS color fills #5

Closed benstr closed 9 years ago

benstr commented 9 years ago

Instead of your framework using .fill-red the css class selector should be .bg-red. the fill selector should be reserved for SVG elements that use fill as a real property.

I currently have a project using SVG icons. If I want to use your framework and make a CSS selector to change the fill of my SVGs, currently I cannot use the logical:

.fill-red {
  fill: red;
}

Because your .fill-red will add an additional background of red too as CSS will naturally cascade.

kkortes commented 9 years ago

You got a good point. Svg's are great and should be used for cross platform crispness.

I'll look into this.

kkortes commented 9 years ago

This is now implemented. Thank you for the input.