kkpowar / gmaps-utility-library-dev

Automatically exported from code.google.com/p/gmaps-utility-library-dev
0 stars 0 forks source link

Change MarkerManager show() and hide() routines #35

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Initially reported in Issue 19.

Also related to LabeledMarker 1.1, I notice that the show() and hide() routines 
alter the visibility 
style property.  I've always felt that it is best to alter the display property 
instead for showing 
(display: anything) and hiding (display: none) -- this should improve 
performance if you have 
lots of markers because the browser, when rendering a page, will ignore a 
display:none label div 
completely instead of having to calculate the size of the space to allocate for 
each 
visibility:hidden div.

However, I'm not sure what the show and hide code for a standard marker looks 
like -- I 
suppose if this code alters the visibility property, the code for 
hiding/showing the labels should 
follow suit. Or maybe the marker code should be changed??

Original issue reported on code.google.com by lem...@gmail.com on 26 May 2008 at 4:51

GoogleCodeExporter commented 8 years ago

Original comment by lem...@gmail.com on 26 May 2008 at 4:56

GoogleCodeExporter commented 8 years ago
Our internal code for marker show/hide sets visibility to '' or 'visible'. That
doesn't necessarily mean we're right. If you change it to display none/block and
don't find any issues with that, then I'm fine with the change.

Original comment by pamela.fox on 26 May 2008 at 4:51