kkristof200 / selenium_youtube

Python library to upload videos to YouTube (also watch, like, comment, pin comment) using Selenium.
MIT License
66 stars 23 forks source link

Module not compatible with windows #13

Closed mashuk999 closed 2 years ago

mashuk999 commented 2 years ago
    signal.signal(signal.SIGALRM, self.handle_timeout)
AttributeError: module 'signal' has no attribute 'SIGALRM'. Did you mean: 'SIGABRT'?

After researching, i found we are not able to SIGABRT in windows. I think the issue is with kstopit repo

ethnyl commented 2 years ago

let me know if you find a fix, please. I'm stumped

mashuk999 commented 2 years ago

Not yet. This error is due to a different repo kstopit and that repo depends on another repo. I have found where is the issue but i am currently looking for alternatives to make the module compatible for cross platform.

mashuk999 commented 2 years ago

This issue can be resolved for windows based machine.

Just install kstopit module from my fork: https://github.com/mashuk999/py_kstopit

Pull request is created but till it gets merged you need to install manually

kkristof200 commented 2 years ago

Hey, sorry for the delay. Thanks @mashuk999 for the pr, but I had to reject it, because the signal method was rewritten to use threading. The issue with that is that there is already a function for threading timeout. I've added a generic method to choose with an enum and updated the selenium package to use that enum based on os. On windows it will be threading, otherwise signal.