Closed coxmars closed 1 month ago
Hi @zmalatrax
Implemented and tested the DivMod
hint.
All related tests for DivMod
have passed successfully.
Here are the test results:
About the integration test, you need to add a Cairo program divmod.cairo
in the cairo_programs/cairo/hints
folder that makes use of the DivMod hint.
It should be a simple program focused on this hint, such as
fn main() {
let _ = 17_u32 / 12_u32;
let _ = 17_u32 % 12_u32;
}
Hi @zmalatrax I was able to solve some problems running the integration test haha, it took me a while but I got it done, unit test and integration test ready plus the feedback given, as you can see below it is working so I will open this draft PR to "Ready for review" 🫡
Hi @zmalatrax I already changed the condition as you said and @enitrat I added a new edge case test, if you need something else to be improved just tell me, thanks 🫡
Hi @zmalatrax I applied the changes and add a few more tests ✅
Hi @zmalatrax, I already applied the improvement, thanks 🫡
Hi @zmalatrax,
I've made significant progress on the
DivMod
hint implementation, including updates to thehintName.ts
,hintSchema.ts
,hintHandler.ts
. The core logic is nearly complete, but a few final adjustments are still needed indivMod.ts
. Also, theverified
tag is working according with the contribution guidelines.Status