search

kkrt-labs / cairo-vm-ts

A typescript implementation of the Cairo VM
Apache License 2.0
20 stars 13 forks source link

Test: improve bitwise tests #73

Closed danielcdz closed 5 months ago

danielcdz commented 5 months ago

Summary

zmalatrax commented 5 months ago

You need to format your code, we're using Trunk

Otherwise it looks good, just need to rebase with main

Also, there is a telegram group for the cairo vm ts devs, if you haven't joined yet: https://t.me/cairovmts

danielcdz commented 5 months ago

Hey, @zmalatrax I'm having these issues when trying to format the code:

image image Do you know how to solve them?

zmalatrax commented 5 months ago

Hi @danielcdz It looks like you haven't the cairo-format command available in your PATH (as well as the cairo-compile one I think) You need to install the python Cairo compiler in order to format and compile Cairo Zero programs.

Take a look at Setting up the environment, from the Cairo docs

danielcdz commented 5 months ago

Hi @danielcdz It looks like you haven't the cairo-format command available in your PATH (as well as the cairo-compile one I think) You need to install the python Cairo compiler in order to format and compile Cairo Zero programs.

Take a look at Setting up the environment, from the Cairo docs

Ty! I'm working on Windows, it was difficult to install the compiler hahaha, but I already made it, but idk if is working well, cause when I try to compile a Cairo file using cairo-compile it doesn't do anything

zmalatrax commented 5 months ago

Hi @danielcdz It looks like you haven't the cairo-format command available in your PATH (as well as the cairo-compile one I think) You need to install the python Cairo compiler in order to format and compile Cairo Zero programs. Take a look at Setting up the environment, from the Cairo docs

Ty! I'm working on Windows, it was difficult to install the compiler hahaha, but I already made it, but idk if is working well, cause when I try to compile a Cairo file using cairo-compile it doesn't do anything

Working with Windows usually comes with quite a lot of problems 😅

I'd recommend you to do your dev work on WSL2, quite easy to install and you'll have a linux distro (e.g. ubuntu) 'inside' your windows

danielcdz commented 5 months ago

@zmalatrax code should be formated now! A lot of workaround to be able to run cairo-compile hahaha, ty for all the suggestions and patience!

danielcdz commented 5 months ago

@ClementWalter now my commits are going to be signed! ty for the advice 🫡