search

kkrt-labs / ef-tests

Test runner for ethereum foundation tests
24 stars 19 forks source link

feat: make a test failing if the Cairo VM reverts #524

Open ClementWalter opened 1 year ago

ClementWalter commented 1 year ago

Feature Request

Describe the Feature Request

Some tests are passing because the post state is the right one, but the Cairo VM reverts. We should assert as well that the Cairo VM exit 0.

Additional Context

The Cairo VM should not revert when used regularly, ie when facing a REVERT opcode (see https://github.com/kkrt-labs/kakarot/issues/766).

We will still have few revert cases (Stack overflow, underflow) that we may want to handle as well (need to check what geth does).

ClementWalter commented 2 months ago

is it still to be done @greged93 ?

greged93 commented 2 months ago

@enitrat