kkrt-labs / ef-tests

Test runner for ethereum foundation tests

24 stars 19 forks source link

Readme jq #709

Closed Gerson2102 closed 6 months ago

Gerson2102 commented 6 months ago

Pull Request type

Adding jq for the requirements to contribute.

Time spent on this PR: 1 minute

Resolves: #706

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[X] Documentation content changes
[ ] Testing

Gerson2102 commented 6 months ago

I dont know if it was a good idea have done a git rebase of my branch from main and then do some changes to the readme and open this PR.

enitrat commented 6 months ago

linter does not pass, can you check?

Gerson2102 commented 6 months ago

I'm trying to run locally trunk fmt but it does not appear the readme. Which is the file that is not formated according to the error. So i cant add the file to commit it. I dont know why it does not appear.

Gerson2102 commented 6 months ago

These files changed because i did an upgrade, but i dont know if its correct to add those changes to the project.

enitrat commented 6 months ago

trunk is just an aggregator of linter that runs prettier under the hood I think. Here the issue would be that the line is too long