search

kkrt-labs / kakarot-rpc

Kakarot ZK EVM Ethereum RPC adapter
MIT License
106 stars 88 forks source link

dev: replace `starknet_crypto::FieldElement` with starknet-types-core #1233

Closed tcoratger closed 1 hour ago

tcoratger commented 3 weeks ago

Describe the enhancement request

At the moment, we are using an old version of starknet-rs crypto crate. Following the merge of https://github.com/xJonathanLEI/starknet-rs/pull/562, we should migrate to the new version and replace our current FieldElement around the codebase with the new Felt type.

This update involves replacing all instances of the FieldElement type in our codebase with the new Felt type introduced in the update.

Benefits

greged93 commented 3 weeks ago

This will probably lead us to need to bump Katana as well no? Are we blocked there or would that be possible?

tcoratger commented 3 weeks ago

This will probably lead us to need to bump Katana as well no? Are we blocked there or would that be possible?

Yes that's true, just put a blocked tag to remind us that we need to update Katana as well and it's blocked at the moment due to fork issue.

tcoratger commented 1 week ago

blocked by #1245

greged93 commented 4 days ago

I think you can start this whenever you want @eugypalu

tcoratger commented 4 days ago

I think you can start this whenever you want @eugypalu

I think this is already work in progress as far as I understood with our week discussions

eugypalu commented 1 day ago

Current status of the issue:

tcoratger commented 1 day ago

Current status of the issue:

  • The issue is blocked because it is not possible to run the tests without upgrading this: https://github.com/kkrt-labs/blockifier
  • It is possible to run the cargo build without errors, and all FieldElement have been migrated to Felt.

Can you push a draft pr so that we can check what happens with the update of blockifier?

eugypalu commented 1 day ago

Current status of the issue:

  • The issue is blocked because it is not possible to run the tests without upgrading this: https://github.com/kkrt-labs/blockifier
  • It is possible to run the cargo build without errors, and all FieldElement have been migrated to Felt.

Can you push a draft pr so that we can check what happens with the update of blockifier?

Sure, opened: https://github.com/kkrt-labs/kakarot-rpc/pull/1296